Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootgrid doesn't work when navigation property has 1 or 2 #120

Closed
lvv83 opened this issue Apr 7, 2015 · 5 comments
Closed

bootgrid doesn't work when navigation property has 1 or 2 #120

lvv83 opened this issue Apr 7, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@lvv83
Copy link

lvv83 commented Apr 7, 2015

Hello.
This issue already mentioned here (#81), but closed without any fix.

if we set navigation property to 1 or 2 then error raised because this.header (or this.footer) is null.

I replace this (and similar) lines:

headerActions =  this.header.find(selector),
footerActions = this.footer.find(selector);

with

headerActions = this.header ? this.header.find(selector) : [],
footerActions = this.footer ? this.footer.find(selector) : [];

and its work!

@rstaib
Copy link
Owner

rstaib commented Apr 7, 2015

I have fixed it already here but I have some more points on my checklist before releasing the next version. Thanks anyway and of course for creating the ticket for transparency.

@rstaib rstaib added the bug label Apr 7, 2015
@rstaib rstaib self-assigned this Apr 7, 2015
@rstaib rstaib added this to the 1.2.0 milestone Apr 7, 2015
@rstaib
Copy link
Owner

rstaib commented Apr 8, 2015

Fixed in version 1.2.0 which will be publicly available within the next few days.

@rstaib rstaib closed this as completed Apr 8, 2015
@lvv83
Copy link
Author

lvv83 commented Apr 9, 2015

Thanks!

@rstaib
Copy link
Owner

rstaib commented Apr 17, 2015

I have recently published the release candidate (prerelease version including all features) to NPM and NuGet. Would be nice and very appreciated to get your feedback before publishing it.

@lvv83
Copy link
Author

lvv83 commented Apr 18, 2015

Well, I already use bootgrid from fixes-and-features branch. It's works properly with navigation.
Prerelease version from Nuget without navigation bugs too.

I have some questions, which not related to this issue. I'm novice with your great component, so I need for some time to learn examples and research.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants