fix(kuma-cp) call eventWriter.Send in a separate goroutine #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
nickolaev
approved these changes
Mar 17, 2021
|
did you have any example of this? |
jakubdyszkiewicz
approved these changes
Mar 17, 2021
|
@jakubdyszkiewicz yep, I noticed it while debugging race condition on ExternalServices |
mergify bot
pushed a commit
that referenced
this pull request
Mar 17, 2021
(cherry picked from commit 0fd45e6)
nickolaev
pushed a commit
that referenced
this pull request
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small problem that may cause a deadlock on Memory storage.
Full changelog
eventWriter.Sendin a separate goroutineDocumentation