Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp) Kuma CP restart may cause stale Envoy configs on Universal #1749

Merged
merged 4 commits into from
Apr 8, 2021

Conversation

lobkovilya
Copy link
Contributor

Summary

OnStreamClosed callback could be called either in case the data plane proxy is down or Kuma CP is gracefully shutting down. In case Kuma CP is shutting down we shouldn't delete the Dataplane resource.

Full changelog

  • In OnStreamClosed check if Kuma CP is gracefully shutting down and if so don't delete the Dataplane resource
  • Rename Runtime.CloseCh() to Runtime.ShutdownCh()

Issues resolved

Fix #1738

Documentation

  • not needed

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	pkg/plugins/resources/k8s/native/go.sum
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner April 2, 2021 11:23
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>

# Conflicts:
#	go.sum
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lobkovilya lobkovilya merged commit 1444641 into master Apr 8, 2021
@lobkovilya lobkovilya deleted the fix/dp-lifecycle-unregister branch April 8, 2021 06:55
mergify bot pushed a commit that referenced this pull request Apr 8, 2021
nickolaev pushed a commit that referenced this pull request Apr 8, 2021
…al (#1749) (#1777)

(cherry picked from commit 1444641)

Co-authored-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kuma CP restart may cause stale Envoy configs on Universal
4 participants