fix(kuma-cp) Kuma CP restart may cause stale Envoy configs on Universal #1749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OnStreamClosed
callback could be called either in case the data plane proxy is down or Kuma CP is gracefully shutting down. In case Kuma CP is shutting down we shouldn't delete the Dataplane resource.Full changelog
OnStreamClosed
check if Kuma CP is gracefully shutting down and if so don't delete the Dataplane resourceRuntime.CloseCh()
toRuntime.ShutdownCh()
Issues resolved
Fix #1738
Documentation