chore(*) use go embed #1865
Merged
chore(*) use go embed #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austince
reviewed
Apr 21, 2021
|
I hope we embed Envoy and CoreDNS in |
jakubdyszkiewicz
force-pushed
the
chore/go-16
branch
6 times, most recently
from
891bd13 to
ee44906
Compare
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit c6576a3) # Conflicts: # app/kuma-ui/data/resources/js/app.c6a62a81.js # app/kuma-ui/pkg/resources/data/js/app.c6a62a81.js # app/kuma-ui/pkg/resources/data/js/app.eef14a9f.js # app/kuma-ui/pkg/resources/guidir_vfsdata.go # app/kumactl/pkg/install/k8s/control-plane/helmtemplates_vfsdata.go
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Apr 22, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use Go embed functionality available in Go 16, so we can finally forget about
generate/*make targets.The directory needs to be in the same module as
//go:embed, so I had to create a new go module for HELM chart and also move GUI files to another location.File paths in embed filesystem start without
/as opposed to vsfiles.