test(*) change E2E test of jobs #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
approved these changes
May 10, 2021
mergify bot
pushed a commit
that referenced
this pull request
May 10, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit fdfbe03)
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
May 10, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think due to the slower propagation of policies on CircleCI, sometimes we had a problem with
should sync traffic permissions.The test
should sync traffic permissionsdiverged to not be about syncing traffic permissions, but many different things.For traffic permissions, we now have a dedicated test suite including hybrid deployment, so I don't think it belongs here.
I changed this and the previous test and this one to be about Jobs, because it's what we testing here.
I noticed that for failing job we are waiting for very long time! I don't think it's ok to slow down tests by a couple of minutes to just to check that CP does not remove job. I did not found a clean way to test it, so in the end I removed this case, it is covered by unit test.
If you think that it is essential to keep this test case of a failing job, I can spend a day figuring this out.