adding postgres max idle connections configuration #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nikita15p <nikita15p@gmail.com>
Signed-off-by: nikita15p <nikita15p@gmail.com>
Signed-off-by: nikita15p <nikita15p@gmail.com>
nikita15p
changed the title
Signed-off-by: nikita15p <nikita15p@gmail.com>
jakubdyszkiewicz
requested changes
May 21, 2021
Signed-off-by: nikita15p <nikita15p@gmail.com>
|
@jakubdyszkiewicz Please review |
jakubdyszkiewicz
approved these changes
May 26, 2021
| @@ -29,6 +29,9 @@ store: | |||
| # Maximum number of open connections to the database | |||
| # `0` value means number of open connections is unlimited | |||
| maxOpenConnections: 0 # ENV: KUMA_STORE_POSTGRES_MAX_OPEN_CONNECTIONS | |||
| # Maximum number of connections in the idle connection pool | |||
| # <0 value means no idle connections and 0 means default max idle connections | |||
| maxIdleConnections: 0 # ENV: KUMA_STORE_POSTGRES_MAX_IDLE_CONNECTIONS | |||
There was a problem hiding this comment.
I'm looking at https://golang.org/src/database/sql/sql.go. There are also following settings:
maxLifetime time.Duration // maximum amount of time a connection may be reused
maxIdleTime time.Duration // maximum amount of time a connection may be idle before being closed
That are default by zero and I'm looking at connectionCleanerRunLocked implementation. Does it mean that once the connection is created it is never closed now?
There was a problem hiding this comment.
Yes, these values are 0 by default and the connections open/idle do not close by its age. If we have idle connections configured, it will use already open connections and will improve performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently maximum idle connections are not configurable for postgres db.
Full changelog
Issues resolved
Fix NA
Documentation
Reference: https://golang.org/src/database/sql/sql.go
Testing