chore(*) remove API V2 #2119
Merged
chore(*) remove API V2 #2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nickolaev
reviewed
Jun 7, 2021
| - images | ||
| - check | ||
| # custom parameters | ||
| api: v2 |
There was a problem hiding this comment.
Shall we remove the whole API versionning machnienry here, or we keep it in preparation for v4?
There was a problem hiding this comment.
Let's keep it! We should be able to add V4 as quickly as possible in the future.
nickolaev
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed API V2 for 1.2.x release. It's not available at all in Envoy 1.18. We had V3 by default in 1.1.x line and supported both V3 and V2 there, it's time to drop this support.
Documentation
Testing