Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) upgrade gui to new version #2340

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

tomaszwylezek
Copy link
Contributor

Signed-off-by: Tomasz Wylężek tomwylezek@gmail.com

Summary

PR: kumahq/kuma-gui#175

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
@tomaszwylezek tomaszwylezek requested a review from a team as a code owner July 9, 2021 09:04
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #2340 (e1b7ec0) into master (9ab0bf4) will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2340      +/-   ##
==========================================
+ Coverage   50.50%   50.86%   +0.35%     
==========================================
  Files         875      879       +4     
  Lines       40794    40827      +33     
==========================================
+ Hits        20603    20766     +163     
+ Misses      18201    18040     -161     
- Partials     1990     2021      +31     
Impacted Files Coverage Δ
pkg/core/resources/manager/cache.go 77.46% <0.00%> (-2.82%) ⬇️
api/internal/util/proto/types.go 100.00% <0.00%> (ø)
api/internal/util/proto/proto.go 62.50% <0.00%> (ø)
...k8s/native/controllers/proxytemplate_controller.go 0.00% <0.00%> (ø)
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
api/observability/v1/mads.pb.go 35.94% <0.00%> (+1.30%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 81.57% <0.00%> (+1.31%) ⬆️
pkg/insights/resyncer.go 61.50% <0.00%> (+1.40%) ⬆️
api/mesh/v1alpha1/dataplane_helpers.go 77.84% <0.00%> (+1.70%) ⬆️
pkg/mads/v1/client/client.go 43.66% <0.00%> (+2.81%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab0bf4...e1b7ec0. Read the comment docs.

@tomaszwylezek tomaszwylezek merged commit 2119fe2 into kumahq:master Jul 9, 2021
@tomaszwylezek tomaszwylezek deleted the chore/upgrade-gui branch July 9, 2021 11:21
mergify bot pushed a commit that referenced this pull request Jul 9, 2021
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
(cherry picked from commit 2119fe2)
tomaszwylezek added a commit that referenced this pull request Jul 9, 2021
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
(cherry picked from commit 2119fe2)

Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants