Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kumactl) add install tracing context #2343

Merged

Conversation

bartsmykla
Copy link
Contributor

Summary

refactor kumactl install tracing to move arguments to separate context

Full changelog

  • [Implement ...]
  • [Fix ...]

Issues resolved

Fix #XXX

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner July 9, 2021 15:03
@codecov-commenter
Copy link

Codecov Report

Merging #2343 (84732cd) into master (2119fe2) will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2343      +/-   ##
==========================================
+ Coverage   50.56%   50.88%   +0.32%     
==========================================
  Files         875      880       +5     
  Lines       40794    40829      +35     
==========================================
+ Hits        20626    20776     +150     
+ Misses      18173    18030     -143     
- Partials     1995     2023      +28     
Impacted Files Coverage Δ
...ctl/cmd/install/context/install_tracing_context.go 100.00% <100.00%> (ø)
app/kumactl/cmd/install/install.go 100.00% <100.00%> (ø)
app/kumactl/cmd/install/install_tracing.go 63.63% <100.00%> (-4.37%) ⬇️
app/kumactl/pkg/cmd/root_context.go 79.41% <100.00%> (+0.20%) ⬆️
pkg/core/resources/store/customizable_store.go 81.81% <0.00%> (-9.10%) ⬇️
pkg/plugins/resources/memory/store.go 75.31% <0.00%> (-4.44%) ⬇️
pkg/core/resources/manager/cache.go 80.28% <0.00%> (-2.82%) ⬇️
...k8s/native/controllers/proxytemplate_controller.go 0.00% <0.00%> (ø)
api/internal/util/proto/proto.go 62.50% <0.00%> (ø)
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2119fe2...84732cd. Read the comment docs.

@bartsmykla bartsmykla merged commit b0c72d1 into kumahq:master Jul 14, 2021
@bartsmykla bartsmykla deleted the feat/add-install-tracing-context branch July 14, 2021 07:56
mergify bot pushed a commit that referenced this pull request Jul 14, 2021
Signed-off-by: Bart Smykla <bartek@smykla.com>
(cherry picked from commit b0c72d1)
bartsmykla added a commit that referenced this pull request Jul 14, 2021
Signed-off-by: Bart Smykla <bartek@smykla.com>
(cherry picked from commit b0c72d1)

Co-authored-by: Bart Smykla <bartek@smykla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants