Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp) handle missing connection info #2439

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

https://github.com/kumahq/kuma/pull/2342/files#diff-4e677d8a7546b3383197877f4c14437d4b356b1ef10a13d7c81fdc8e05b45632R65 was merged without resolving the todo.

In a case when we spin down data plane proxy, technically we can remove connection info from the map and still have one more Sync in DP watchdog. When this happens, CP fails.

Documentation

  • No docs

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #2439 (0e84bb3) into master (09fc104) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2439   +/-   ##
=======================================
  Coverage   52.58%   52.58%           
=======================================
  Files         878      878           
  Lines       47896    47904    +8     
=======================================
+ Hits        25185    25192    +7     
+ Misses      20667    20663    -4     
- Partials     2044     2049    +5     
Impacted Files Coverage Δ
pkg/xds/sync/dataplane_watchdog.go 0.00% <0.00%> (ø)
pkg/xds/sync/xds_context_builder.go 21.21% <0.00%> (-4.72%) ⬇️
pkg/kds/client/sink.go 47.72% <0.00%> (-4.55%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
pkg/core/resources/manager/cache.go 84.41% <0.00%> (+5.19%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09fc104...0e84bb3. Read the comment docs.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 2bc0a3f into master Jul 27, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the fix/handle-missing-connection-info branch July 27, 2021 09:45
mergify bot pushed a commit that referenced this pull request Jul 27, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 2bc0a3f)
jakubdyszkiewicz pushed a commit that referenced this pull request Jul 27, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants