chore(tools): add to resource-gen.go generation of kumactl options #2469

lahabana · 2021-07-30T14:44:34Z

First commit is #2466

codecov-commenter · 2021-07-30T15:20:40Z

Codecov Report

Merging #2469 (421ea72) into master (4d7e7c0) will decrease coverage by 0.06%.
The diff coverage is 53.96%.

@@            Coverage Diff             @@
##           master    #2469      +/-   ##
==========================================
- Coverage   52.56%   52.50%   -0.07%     
==========================================
  Files         887      867      -20     
  Lines       48394    48383      -11     
==========================================
- Hits        25439    25402      -37     
- Misses      20906    20931      +25     
- Partials     2049     2050       +1

Impacted Files	Coverage Δ
api/mesh/options.pb.go	`19.09% <0.00%> (-6.52%)`	⬇️
api/mesh/v1alpha1/circuit_breaker.pb.go	`46.08% <ø> (ø)`
api/mesh/v1alpha1/dataplane.pb.go	`37.85% <ø> (ø)`
api/mesh/v1alpha1/dataplane_insight.pb.go	`41.66% <ø> (ø)`
api/mesh/v1alpha1/dataplane_overview.pb.go	`43.28% <ø> (ø)`
api/mesh/v1alpha1/externalservice.pb.go	`51.65% <ø> (ø)`
api/mesh/v1alpha1/fault_injection.pb.go	`47.29% <ø> (ø)`
api/mesh/v1alpha1/gateway.pb.go	`33.57% <ø> (ø)`
api/mesh/v1alpha1/health_check.pb.go	`30.54% <ø> (ø)`
api/mesh/v1alpha1/mesh.pb.go	`32.60% <ø> (ø)`
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7e7c0...421ea72. Read the comment docs.

jpeach · 2021-08-02T02:18:24Z

app/kumactl/pkg/entities/entities.go

+		// Preserve backward compatibility for this typo before this was auto generated
+		if All[i].Singular == "health-check" {
+			All[i].Plural = "healthchecks"
+			All[i].Singular = "healthcheck"


proxytemplate is wrong in the same way?

Proxy template is wrong is a different way:

Healthcheck has a rest endpoint: health-check and a kumactl healthcheck

Proxytemplate: has both rest and kumactl to proxytemplate

So for proxytemplate while it's incoherent with how we right things it's coherent between rest and kumactl so no need to do an exception here.

api/mesh/options.proto

jpeach · 2021-08-02T04:11:00Z

app/kumactl/pkg/cmd/root_context.go

@@ -103,15 +84,11 @@ func DefaultRootContext() *RootContext {
 }

 func (rc *RootContext) TypeForArg(arg string) (core_model.ResourceType, error) {
-	typ, ok := rc.TypeArgs[arg]
+	typ, ok := entities.ByName[arg]


IIUC, this needs to skip insight type that users should not delete.

I've done this with a better error message just down there

This removes some more manually written code that currently makes policy creation error prone Signed-off-by: Charly Molter <charly.molter@konghq.com>

lahabana · 2021-08-03T15:36:16Z

app/kumactl/cmd/completion/testdata/bash.golden

+    flags+=("--offset=")
+    two_word_flags+=("--offset")
+    flags+=("--size=")
+    two_word_flags+=("--size")


For some reasons there was no pagination on secrets and global secrets. @jakubdyszkiewicz do you know if it was for a specific reason?

lahabana · 2021-08-03T15:43:29Z

I've forced-push because it was very different from the original.
I've taken into account you suggestion and also moved the ws inside the extension to keep things simple (like I mentioned in #2466).

Adding custom table printer is now simpler and doesn't rely on funky codegen.

app/kumactl/pkg/entities/entities.go

jpeach

Just a few nits and quibbles.

app/kumactl/cmd/get/table_printer.go

app/kumactl/pkg/cmd/root_context.go

app/kumactl/pkg/entities/entities.go

pkg/plugins/runtime/gateway/kumactl/plugin.go

Signed-off-by: Charly Molter <charly.molter@konghq.com>

…umactldefs Signed-off-by: Charly Molter <charly.molter@konghq.com>

…2469) This removes some more manually written code that currently makes policy creation error prone Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit aa0bd89) # Conflicts: # pkg/plugins/runtime/gateway/kumactl/plugin.go

…2469) This removes some more manually written code that currently makes policy creation error prone Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit aa0bd89)

…2469) (#2504) This removes some more manually written code that currently makes policy creation error prone Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit aa0bd89) Co-authored-by: Charly Molter <charly.molter@konghq.com>

lahabana requested a review from jpeach July 30, 2021 14:44

lahabana requested a review from a team as a code owner July 30, 2021 14:44

lahabana force-pushed the chore/generate_kumactldefs branch from 5987f76 to 421ea72 Compare July 30, 2021 14:50

lahabana added the backport-to-stable label Jul 30, 2021

jpeach reviewed Aug 2, 2021

View reviewed changes

api/mesh/options.proto Outdated Show resolved Hide resolved

jpeach reviewed Aug 2, 2021

View reviewed changes

api/mesh/options.proto Outdated Show resolved Hide resolved

jpeach reviewed Aug 2, 2021

View reviewed changes

jpeach mentioned this pull request Aug 2, 2021

feat(*) register the gateway resource type #2474

Merged

5 tasks

chore(ci): Add kumactl to resource-gen.go

766181e

This removes some more manually written code that currently makes policy creation error prone Signed-off-by: Charly Molter <charly.molter@konghq.com>

lahabana force-pushed the chore/generate_kumactldefs branch from 421ea72 to 766181e Compare August 3, 2021 15:35

lahabana commented Aug 3, 2021

View reviewed changes

lahabana requested a review from jpeach August 3, 2021 15:41

jpeach reviewed Aug 4, 2021

View reviewed changes

app/kumactl/pkg/entities/entities.go Show resolved Hide resolved

jpeach approved these changes Aug 5, 2021

View reviewed changes

lahabana added 2 commits August 5, 2021 14:38

Review comments

4b76fd3

Signed-off-by: Charly Molter <charly.molter@konghq.com>

Merge branch 'master' of github.com:kumahq/kuma into chore/generate_k…

5e5b8ee

…umactldefs Signed-off-by: Charly Molter <charly.molter@konghq.com>

lahabana merged commit aa0bd89 into kumahq:master Aug 5, 2021

mergify bot mentioned this pull request Aug 5, 2021

chore(tools): add to resource-gen.go generation of kumactl options (backport #2469) #2504

Merged

lahabana deleted the chore/generate_kumactldefs branch March 29, 2024 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(tools): add to resource-gen.go generation of kumactl options #2469

chore(tools): add to resource-gen.go generation of kumactl options #2469

lahabana commented Jul 30, 2021

codecov-commenter commented Jul 30, 2021

jpeach Aug 2, 2021

lahabana Aug 2, 2021

jpeach Aug 2, 2021

lahabana Aug 3, 2021

lahabana Aug 3, 2021

lahabana commented Aug 3, 2021

jpeach left a comment

chore(tools): add to resource-gen.go generation of kumactl options #2469

chore(tools): add to resource-gen.go generation of kumactl options #2469

Conversation

lahabana commented Jul 30, 2021

codecov-commenter commented Jul 30, 2021

Codecov Report

jpeach Aug 2, 2021

Choose a reason for hiding this comment

lahabana Aug 2, 2021

Choose a reason for hiding this comment

jpeach Aug 2, 2021

Choose a reason for hiding this comment

lahabana Aug 3, 2021

Choose a reason for hiding this comment

lahabana Aug 3, 2021

Choose a reason for hiding this comment

lahabana commented Aug 3, 2021

jpeach left a comment

Choose a reason for hiding this comment