feat(dns): Rewrite dns persistence to allow virtual-outbound to be added #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the persisted state on the vips was very restraining. With the addition of virtual-outbounds we'll need something more flexible This migrates the state to a new format that will be extensible. Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana
force-pushed
the
feat/virtual-outbound_dnspersistence
branch
from
1188d51 to
7d7785c
Compare
This avoids computing the same thing twice. Now that allocator persists the correct configuration we can just reuse this Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana
force-pushed
the
feat/virtual-outbound_dnspersistence
branch
from
1f3f318 to
952b21e
Compare
…bound_dnspersistence Signed-off-by: Charly Molter <charly.molter@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2484 +/- ##
=======================================
Coverage 52.28% 52.28%
=======================================
Files 865 866 +1
Lines 48098 48130 +32
=======================================
+ Hits 25147 25165 +18
- Misses 20919 20926 +7
- Partials 2032 2039 +7
Continue to review full report at Codecov.
|
lobkovilya
reviewed
Aug 9, 2021
pkg/dns/vips/virtual_outbound.go
Outdated
| oldVob, ok := vo.byHostname[entry] | ||
| if ok { | ||
| if !oldVob.Equal(vob) { | ||
| changes = append(changes, Change{Type: Modify, Entry: entry}) |
There was a problem hiding this comment.
When we add a new outbound (for example same host but different port).
lahabana
force-pushed
the
feat/virtual-outbound_dnspersistence
branch
from
b2a03a7 to
386edb8
Compare
Signed-off-by: Charly Molter <charly.molter@konghq.com>
…bound_dnspersistence Signed-off-by: Charly Molter <charly.molter@konghq.com>
lobkovilya
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the persisted state on the vips was very restraining.
With the addition of virtual-outbounds we'll need something more flexible
This migrates the state to a new format that will be extensible.
It also avoids reusing vips straight away which might avoid some issues when services are added and removed at once.