Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp) add virtual host domain name configurer #2590

Merged
merged 1 commit into from
Aug 18, 2021
Merged

feat(kuma-cp) add virtual host domain name configurer #2590

merged 1 commit into from
Aug 18, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Aug 17, 2021

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • [-] Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner August 17, 2021 23:38
@codecov-commenter
Copy link

Codecov Report

Merging #2590 (f33ddb6) into master (a931218) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
+ Coverage   52.16%   52.21%   +0.04%     
==========================================
  Files         869      869              
  Lines       48568    48576       +8     
==========================================
+ Hits        25337    25365      +28     
+ Misses      21185    21163      -22     
- Partials     2046     2048       +2     
Impacted Files Coverage Δ
pkg/xds/envoy/routes/configurers.go 100.00% <100.00%> (ø)
pkg/xds/envoy/routes/virtual_host_builder.go 84.61% <100.00%> (+0.61%) ⬆️
pkg/kds/client/sink.go 47.72% <0.00%> (-4.55%) ⬇️
pkg/core/resources/manager/cache.go 81.81% <0.00%> (ø)
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/dns/vips_allocator.go 75.63% <0.00%> (+1.68%) ⬆️
pkg/insights/resyncer.go 65.81% <0.00%> (+1.70%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
pkg/insights/components.go 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a931218...f33ddb6. Read the comment docs.

@jpeach jpeach merged commit d705027 into kumahq:master Aug 18, 2021
mergify bot pushed a commit that referenced this pull request Aug 18, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit d705027)
@jpeach jpeach deleted the feat/domain-name-configurer branch August 18, 2021 22:16
jpeach added a commit that referenced this pull request Aug 18, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit d705027)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants