Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) open CAProvider and MeshValidator for extensions #2618

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Expose CAProvider and MeshValidators as Runtime components.

Issues resolved

No fix.

Documentation

  • No docs, internal changes only.

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Although this is not a breaking change - we don't want to backport it.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner August 20, 2021 11:39
@codecov-commenter
Copy link

Codecov Report

Merging #2618 (148b279) into master (40ee4f7) will increase coverage by 0.02%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2618      +/-   ##
==========================================
+ Coverage   52.29%   52.32%   +0.02%     
==========================================
  Files         869      869              
  Lines       48711    48735      +24     
==========================================
+ Hits        25474    25501      +27     
+ Misses      21191    21183       -8     
- Partials     2046     2051       +5     
Impacted Files Coverage Δ
pkg/plugins/runtime/k8s/plugin.go 1.17% <0.00%> (+0.02%) ⬆️
pkg/core/runtime/runtime.go 82.14% <50.00%> (-2.48%) ⬇️
pkg/core/runtime/builder.go 63.95% <62.50%> (-0.13%) ⬇️
pkg/core/managers/apis/mesh/mesh_validator.go 76.59% <82.35%> (+4.80%) ⬆️
pkg/core/bootstrap/bootstrap.go 63.07% <100.00%> (-0.16%) ⬇️
pkg/test/runtime/runtime.go 89.47% <100.00%> (ø)
pkg/xds/server/components.go 58.82% <100.00%> (ø)
pkg/core/resources/store/customizable_store.go 77.77% <0.00%> (-11.12%) ⬇️
pkg/plugins/resources/memory/store.go 77.71% <0.00%> (-4.35%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ee4f7...148b279. Read the comment docs.

@jakubdyszkiewicz jakubdyszkiewicz merged commit ab55603 into master Aug 23, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/open-ca-provider-and-validator branch August 23, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants