Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics) add zone selector to Kuma Mesh dashboard #2860

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 30, 2021

Summary

Add a zone selector to Kuma Mesh dashboard
zone_selector
Only the Service Map is not filtered in any way

Full changelog

  • feat(metrics) add zone selector to Kuma Mesh dashboard
  • tests(integration) incorporate Kuma Mesh zone changes

Testing

  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@michaelbeaumont michaelbeaumont marked this pull request as ready for review September 30, 2021 18:45
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 30, 2021 18:45
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2021

Codecov Report

Merging #2860 (0692656) into master (55676cf) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2860      +/-   ##
==========================================
+ Coverage   52.13%   52.17%   +0.03%     
==========================================
  Files         897      897              
  Lines       52070    52070              
==========================================
+ Hits        27149    27166      +17     
+ Misses      22749    22734      -15     
+ Partials     2172     2170       -2     
Impacted Files Coverage Δ
pkg/core/runtime/component/component.go 81.13% <0.00%> (-7.55%) ⬇️
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/core/resources/model/rest/resource.go 69.23% <0.00%> (+1.28%) ⬆️
pkg/mads/server/server.go 84.25% <0.00%> (+1.85%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/plugins/leader/postgres/leader_elector.go 97.87% <0.00%> (+4.25%) ⬆️
pkg/xds/cache/once/cache.go 94.87% <0.00%> (+7.69%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55676cf...0692656. Read the comment docs.

@michaelbeaumont michaelbeaumont marked this pull request as draft October 4, 2021 12:57
@michaelbeaumont michaelbeaumont marked this pull request as ready for review October 4, 2021 13:38
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont merged commit 26f2d23 into kumahq:master Oct 6, 2021
@michaelbeaumont michaelbeaumont deleted the feat/kuma-mesh-zone branch October 6, 2021 19:28
mergify bot pushed a commit that referenced this pull request Oct 6, 2021
* feat(metrics) add zone selector to Kuma Mesh dashboard

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

* tests(integration) incorporate Kuma Mesh zone changes

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 26f2d23)
michaelbeaumont added a commit that referenced this pull request Oct 6, 2021
* feat(metrics) add zone selector to Kuma Mesh dashboard

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

* tests(integration) incorporate Kuma Mesh zone changes

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 26f2d23)

Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants