-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*) update base image for kuma-dp #2881
chore(*) update base image for kuma-dp #2881
Conversation
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Why glibc? What is the origin and support policy for the image? |
@jpeach it's the base image that envoy-alipne uses, so we were using it implicitly already. |
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> (cherry picked from commit f8791fc)
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
I'm pretty uncomfortable depending on a base image where we don't know the origin and maintainer, or have any information about its quality of provenance. Its one thing for envoy to take on that risk, it's another thing for us to take it on without any analysis that I can see. Do we expect this change to be permanent? I see that the base image for envoy-alpine is updated in main, so we would get this change for free with envoy 1.20. Finally, was any comparison made with other base images? Ubuntu doesn't look like it would be substantially smaller and would improve the ability to troubleshoot envoy containers. Google distroless would be substantially smaller.
|
Well, I underestimated the size of the envoy binary:
|
Summary
Update base image to alpine:3.14
Full changelog
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stable
label if the code is backwards compatible. Otherwise, list breaking changes.