feat(kuma-cp) aggregate services in MeshInsight #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this changes MeshInsights will contain `services` field, with amount of external and internal services for mesh Signed-off-by: Bart Smykla <bartek@smykla.com>
Codecov Report
@@ Coverage Diff @@
## master #2974 +/- ##
==========================================
- Coverage 52.38% 52.37% -0.02%
==========================================
Files 912 912
Lines 52522 52581 +59
==========================================
+ Hits 27514 27537 +23
- Misses 22814 22847 +33
- Partials 2194 2197 +3
Continue to review full report at Codecov.
|
jakubdyszkiewicz
approved these changes
Oct 19, 2021
jpeach
reviewed
Oct 20, 2021
Comment on lines
+341
to
+342
| // Builtin gateways have inbounds | ||
| if dpOverview.Spec.Dataplane.IsDelegatedGateway() { |
There was a problem hiding this comment.
Not sure which is right here. The comment references builtin gateways but the code references deletegated gateways?
There was a problem hiding this comment.
OK, I see ... the condition is backwards :-(
jpeach
reviewed
Oct 20, 2021
|
|
||
| // Builtin gateways have inbounds | ||
| if dpOverview.Spec.Dataplane.IsDelegatedGateway() { | ||
| svcName := dpOverview.Spec.Dataplane.Networking.GetGateway().GetTags()[mesh_proto.ServiceTag] |
There was a problem hiding this comment.
Please consistently use the protobuf Get prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this changes MeshInsights will contain
servicesfield,with amount of external and internal services for mesh
Full changelog
no change log
Issues resolved
none issue resolved
Documentation
In progress
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.