Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*) add more global resources to GlobalInsights #3094

Conversation

bartsmykla
Copy link
Contributor

@bartsmykla bartsmykla commented Nov 5, 2021

Summary

Any global resource, which is not Config or suffixed by Insight
will be returned in GlobalInsights endpoint

Example response:

{
 "type": "GlobalInsights",
 "creationTime": "2021-11-05T08:11:37.880477+01:00",
 "resources": {
  "GlobalSecret": {
   "total": 3
  },
  "Mesh": {
   "total": 1
  },
  "Zone": {
   "total": 0
  },
  "ZoneIngress": {
   "total": 0
  }
 }
}

Full changelog

no changelog

Issues resolved

no issue resolved

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Any global resource, which is not `Config` or suffixed by `Insight`
will be returned in GlobalInsights endpoint

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from a team as a code owner November 5, 2021 07:17
@bartsmykla bartsmykla changed the title feat(*) add more global resources to GlobalInsight feat(*) add more global resources to GlobalInsights Nov 5, 2021
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla merged commit 168b8ee into kumahq:master Nov 5, 2021
@bartsmykla bartsmykla deleted the feat/add-more-global-resources-to-global-insights branch November 5, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants