-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*) scripts for build, publish and fetch Envoy binaries #3110
Conversation
…g Envoy binaries Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the uploading of the binaries also be covered in the next PR?
xref #2627 |
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #3110 +/- ##
==========================================
+ Coverage 52.35% 52.36% +0.01%
==========================================
Files 919 919
Lines 53208 53208
==========================================
+ Hits 27855 27864 +9
+ Misses 23124 23123 -1
+ Partials 2229 2221 -8
Continue to review full report at Codecov.
|
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just nits left. Overall, this is 🔥
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> (cherry picked from commit 6f2071e)
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> (cherry picked from commit 6f2071e)
Summary
Current PR introduces targets
make build/envoy
that allows to build and fetch Envoy binaries (see README.md).Also, current PR changes the way
kuma-dp
image obtains Envoy binary. Previously we copied Envoy binary fromenvoyproxy/envoy-alpine
image:Now we copy the binary from
build/artifact-*
directory:In order for Envoy binary to appear in
build/artifacts-*
directory, we must callmake build/artifacts-darwin-amd64/envoy
target. This is not a.PHONY
target which means it won't run if binary already exists.Target
build/artifacts-%-amd64/envoy
runs in 2 modes: fetch required binary from download.konghq.com or build the binary from source code. Modes could be switched usingBUILD_ENVOY_FROM_SOURCES
variable, default behavior is fetching soBUILD_ENVOY_FROM_SOURCES=false
.Note: This PR doesn't affect CI or change the Envoy version. These changes will be presented in another PRs.
Full changelog
Issues resolved
N/A
Documentation
Testing
Backwards compatibility
backport-to-stable
label if the code is backwards compatible. Otherwise, list breaking changes.