Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kuma-cp) do not override other dataplane with dp lifecycle #3507

Merged
merged 3 commits into from
Dec 16, 2021
Merged

fix(kuma-cp) do not override other dataplane with dp lifecycle #3507

merged 3 commits into from
Dec 16, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

With the current implementation of DP lifecycle, you could override other DP when the new token is was issued for mesh + kuma.io/service tag

Issues resolved

No issue reported.

Documentation

  • No extra docs, internal changes only

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • No UPGRADE.md notes
  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner December 14, 2021 13:26
@jakubdyszkiewicz
fix(kuma-cp): do not override other dataplane with dp lifecycle
d71ea69 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@jakubdyszkiewicz
review remarks
727c546 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3507 (727c546) into master (4b96e9d) will decrease coverage by 0.04%.
The diff coverage is 25.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3507      +/-   ##
==========================================
- Coverage   51.57%   51.52%   -0.05%     
==========================================
  Files         917      918       +1     
  Lines       55493    55566      +73     
==========================================
+ Hits        28619    28631      +12     
- Misses      24587    24657      +70     
+ Partials     2287     2278       -9
Impacted Files Coverage Δ
test/e2e/auth/dp/dp_auth_universal.go 0.00% <0.00%> (ø)
test/framework/universal_controlplane.go 0.00% <0.00%> (ø)
pkg/xds/server/callbacks/dataplane_lifecycle.go 70.88% <64.28%> (+3.19%) ⬆️
pkg/util/proto/proto.go 49.12% <100.00%> (+1.85%) ⬆️
pkg/xds/auth/callbacks.go 78.82% <100.00%> (+2.35%) ⬆️
pkg/xds/server/v3/components.go 77.61% <100.00%> (ø)
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
pkg/events/eventbus.go 85.18% <0.00%> (-7.41%) ⬇️
pkg/plugins/runtime/gateway/route/sorter.go 66.66% <0.00%> (-5.13%) ⬇️
pkg/insights/resyncer.go 71.16% <0.00%> (-2.46%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b96e9d...727c546. Read the comment docs.

lahabana
lahabana approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one remark but I think it's not directly related to this change.

pkg/xds/server/callbacks/dataplane_lifecycle.go Show resolved Hide resolved
@jakubdyszkiewicz
add extra explanation
731b654 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
michaelbeaumont
michaelbeaumont approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubdyszkiewicz jakubdyszkiewicz enabled auto-merge (squash) December 16, 2021 09:36
@jakubdyszkiewicz jakubdyszkiewicz merged commit f464b5b into master Dec 16, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the fix/dp-overriding branch December 16, 2021 09:57
mergify bot pushed a commit that referenced this pull request Dec 16, 2021
@jakubdyszkiewicz
fix(kuma-cp) do not override other dataplane with dp lifecycle (#3507)
e18c707 
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit f464b5b)
@mergify mergify bot mentioned this pull request Dec 16, 2021
Merged
mergify bot added a commit that referenced this pull request Dec 16, 2021
@mergify @jakubdyszkiewicz
fix(kuma-cp) do not override other dataplane with dp lifecycle (#3507) (
44d4cdd 
#3561)

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit f464b5b)

Co-authored-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@jpeach jpeach Awaiting requested review from jpeach

@parkanzky parkanzky Awaiting requested review from parkanzky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jakubdyszkiewicz @codecov-commenter @jpeach @lahabana @michaelbeaumont @parkanzky