feat(*) allow ca.crt to be in separate k8s secret #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature adds option to provide ca.crt in separate k8s secret than tls.key/tls.crt, which allows to provide CA and certificates using for example cert-manager + two small stylistic changes in helm chart's values.yaml file suggested by my IDE Signed-off-by: Bart Smykla <bartek@smykla.com>
bartsmykla
force-pushed
the
feat/separate-secrets-for-ca-crt
branch
from
73a9160 to
7e335bf
Compare
lahabana
reviewed
Jan 4, 2022
Signed-off-by: Bart Smykla <bartek@smykla.com>
Now we do (I moved the flag to different test case) |
Signed-off-by: Bart Smykla <bartek@smykla.com>
Codecov Report
@@ Coverage Diff @@
## master #3638 +/- ##
==========================================
- Coverage 50.94% 50.92% -0.02%
==========================================
Files 928 928
Lines 56414 56415 +1
==========================================
- Hits 28740 28732 -8
- Misses 25395 25398 +3
- Partials 2279 2285 +6
Continue to review full report at Codecov.
|
jakubdyszkiewicz
approved these changes
Jan 10, 2022
Signed-off-by: Bart Smykla <bartek@smykla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This feature adds option to provide ca.crt in separate k8s secret
than tls.key/tls.crt, which allows to provide CA and certificates
using for example cert-manager
suggested by my IDE
Full changelog
No changelog
Issues resolved
Closes #3015
Documentation
Testing
Backwards compatibility
UPGRADE.mdwith any steps users will need to takewhen upgrading.
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.