Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kumactl): inspect api support #3805

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Conversation

lobkovilya
Copy link
Contributor

Summary

Current PR introduces new commands for kumactl that enable people to use Inspect API.
New commands:

  • $ kumactl inspect dataplane NAME – see what policies were applied for the DPP
  • $ kumactl inspect dataplane NAME --config-dump – see envoy config dump for DPP
  • $ kumactl inspect zoneingress NAME --config-dump – see envoy config dump for ZoneIngress
  • $ kumactl inspect POLICY NAME -- see what DPPs are affected by policy

Full changelog

  • introduce new kumactl commands
  • enable Inspect API e2e tests

Issues resolved

Fix #3730

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

- [ ] Update UPGRADE.md with any steps users will need to take when upgrading.
- [ ] Add backport-to-stable label if the code follows our backporting policy

Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@lobkovilya lobkovilya requested a review from a team as a code owner February 9, 2022 13:21
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #3805 (576c1a0) into master (b015316) will decrease coverage by 0.05%.
The diff coverage is 40.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3805      +/-   ##
==========================================
- Coverage   55.86%   55.81%   -0.06%     
==========================================
  Files         901      907       +6     
  Lines       53554    53747     +193     
==========================================
+ Hits        29920    29999      +79     
- Misses      21248    21338      +90     
- Partials     2386     2410      +24     
Impacted Files Coverage Δ
.../kumactl/pkg/resources/dataplane_inspect_client.go 0.00% <0.00%> (ø)
app/kumactl/pkg/resources/policy_inspect_client.go 0.00% <0.00%> (ø)
...umactl/pkg/resources/zoneingress_inspect_client.go 0.00% <0.00%> (ø)
app/kumactl/pkg/cmd/root_context.go 58.69% <40.00%> (-2.28%) ⬇️
app/kumactl/cmd/inspect/inspect_zoneingress.go 40.90% <40.90%> (ø)
app/kumactl/cmd/inspect/inspect_dataplane.go 60.00% <60.00%> (ø)
pkg/api-server/types/inspect.go 76.47% <64.70%> (-5.89%) ⬇️
app/kumactl/cmd/inspect/inspect_policy.go 83.78% <83.78%> (ø)
app/kumactl/cmd/inspect/inspect.go 82.60% <100.00%> (+3.66%) ⬆️
pkg/plugins/runtime/gateway/route/sorter.go 61.53% <0.00%> (-10.26%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b015316...576c1a0. Read the comment docs.

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@lobkovilya lobkovilya merged commit 67a4697 into master Feb 10, 2022
@lobkovilya lobkovilya deleted the feat/inspect-api-kumactl branch February 10, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kumactl support for inspect api
3 participants