Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Remove check_cupy8 #3669

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

viclafargue
Copy link
Contributor

Closes #3651

@viclafargue viclafargue requested a review from a team as a code owner March 29, 2021 17:06
@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 29, 2021
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 29, 2021
Copy link
Contributor

@JohnZed JohnZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks from the CI failures that there are a few more cases to remove.

@codecov-io
Copy link

Codecov Report

Merging #3669 (f2a884b) into branch-0.19 (fd9ec89) will increase coverage by 1.51%.
The diff coverage is 91.14%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #3669      +/-   ##
===============================================
+ Coverage        80.70%   82.22%   +1.51%     
===============================================
  Files              227      226       -1     
  Lines            17615    17454     -161     
===============================================
+ Hits             14217    14352     +135     
+ Misses            3398     3102     -296     
Flag Coverage Δ
dask 46.48% <32.00%> (+1.48%) ⬆️
non-dask 74.15% <76.28%> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cuml/_thirdparty/sklearn/preprocessing/__init__.py 100.00% <ø> (ø)
python/cuml/cluster/kmeans.pyx 91.95% <ø> (ø)
python/cuml/common/import_utils.py 57.30% <ø> (-1.75%) ⬇️
python/cuml/fil/fil.pyx 92.85% <ø> (+1.02%) ⬆️
python/cuml/model_selection/_split.py 90.86% <ø> (+0.50%) ⬆️
python/cuml/neighbors/__init__.py 100.00% <ø> (ø)
python/cuml/neighbors/ann.pyx 90.80% <ø> (+29.17%) ⬆️
python/cuml/neighbors/nearest_neighbors.pyx 92.97% <ø> (+0.33%) ⬆️
python/cuml/pipeline/__init__.py 100.00% <ø> (ø)
python/cuml/preprocessing/encoders.py 95.10% <ø> (+0.02%) ⬆️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d1bcf...f2a884b. Read the comment docs.

@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review and removed Cython / Python Cython or Python issue labels Mar 30, 2021
@dantegd
Copy link
Member

dantegd commented Mar 30, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 31, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e1c428a into rapidsai:branch-0.19 Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Waiting on Author Waiting for author to respond to review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Remove check_cupy8 decorator
4 participants