Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Process.Builder.output #20

Closed
05nelsonm opened this issue Feb 8, 2024 · 4 comments · Fixed by #33
Closed

Add Process.Builder.output #20

05nelsonm opened this issue Feb 8, 2024 · 4 comments · Fixed by #33
Labels
enhancement New feature or request

Comments

@05nelsonm
Copy link
Owner

output should take in a Duration for timeout, and return stdout and stderr buffered output

@05nelsonm 05nelsonm added the enhancement New feature or request label Feb 8, 2024
@05nelsonm
Copy link
Owner Author

Adding the blocked label until #2 is completed

@05nelsonm 05nelsonm added the blocked An issue that is blocked by something else label Feb 8, 2024
@05nelsonm
Copy link
Owner Author

05nelsonm commented Feb 9, 2024

Note that stdout and stderr must be Stdio.Pipe. This means the Stdio.Config.Builder should be a data class and it should be copied and updated before being passed as config to platform builder.

Either that, or it should throw an IOException

@05nelsonm
Copy link
Owner Author

Need to implement this for at least Jvm/Js in order to work out the APIs. Will help considerably when working on #2.

@05nelsonm
Copy link
Owner Author

With #31 , this is "completed" as the Jvm implementation is for nonJsMain, just need to link up nativeMain with the function once #2 is done for Native side of the house.

@05nelsonm 05nelsonm added blocked An issue that is blocked by something else and removed blocked An issue that is blocked by something else labels Feb 12, 2024
@05nelsonm 05nelsonm removed the blocked An issue that is blocked by something else label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant