Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make solid repo really multi-app #15

Closed
bourgeoa opened this issue Dec 9, 2021 · 4 comments · Fixed by #17
Closed

make solid repo really multi-app #15

bourgeoa opened this issue Dec 9, 2021 · 4 comments · Fixed by #17
Labels
documentation Improvements or additions to documentation

Comments

@bourgeoa
Copy link
Contributor

bourgeoa commented Dec 9, 2021

Actually there is a reference solid app and and access to other solid versions.

  • hello/solid
    • solid-file-client
    • common solid files and solid app files

I propose an other organisation renaming the solid reference app --> solid-rest-api
We could have :

@NoelDeMartin
Copy link
Member

I like the idea of renaming the reference app to solid-rest-api, but I think extracting more common code for solid could complicate the repo too much. Although maybe it'll be necessary if we have more examples, but only with 2 I think I'd leave it as is (following the rule of 3 :D).

We already have an html listing all the solid versions here: https://hello.0data.app/solid/all.html

@NoelDeMartin NoelDeMartin added the documentation Improvements or additions to documentation label Dec 10, 2021
@bourgeoa
Copy link
Contributor Author

We already have an html listing all the solid versions here: https://hello.0data.app/solid/all.html

Yes I was only thinking of renaming all.html to index.html

I have nothing against the rule of 3

@NoelDeMartin
Copy link
Member

I see, I think I understand what you mean now, you mean to move the files that are currently in solid/ into solid/solid-rest-api and leave in solid/ only the things that are common to all examples?

Ok I think that's a good idea, I'll do it the next time I change something in the repo (or open a PR yourself if you want).

@bourgeoa
Copy link
Contributor Author

That is exactly what I meant.

@rosano rosano linked a pull request Dec 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants