From 13f31f64f42c8ca7610863a6e733f7a418f56bd1 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Fri, 30 Jun 2017 11:20:04 +1000 Subject: [PATCH] powerpc-64s-implement-arch-specific-hardlockup-watchdog-checkpatch-fixes WARNING: line over 80 characters #97: FILE: arch/powerpc/include/asm/smp.h:59: +extern int smp_send_nmi_ipi(int cpu, void (*fn)(struct pt_regs *), u64 delay_us); WARNING: line over 80 characters #119: FILE: arch/powerpc/kernel/exceptions-64s.S:1276: +#if defined(CONFIG_HARDLOCKUP_DETECTOR) && defined(CONFIG_HAVE_HARDLOCKUP_DETECTOR_ARCH) ERROR: do not initialise statics to 0 #317: FILE: arch/powerpc/kernel/watchdog.c:62: +static unsigned long __wd_smp_lock = 0; WARNING: memory barrier without comment #554: FILE: arch/powerpc/kernel/watchdog.c:299: + smp_wmb(); WARNING: Prefer pr_warn(... to pr_warning(... #617: FILE: arch/powerpc/kernel/watchdog.c:362: + pr_warning("Watchdog could not be initialized"); total: 1 errors, 4 warnings, 543 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/powerpc-64s-implement-arch-specific-hardlockup-watchdog.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Nicholas Piggin Signed-off-by: Andrew Morton --- arch/powerpc/kernel/watchdog.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/watchdog.c b/arch/powerpc/kernel/watchdog.c index d46040c0da4045..ae1ed7516eaec5 100644 --- a/arch/powerpc/kernel/watchdog.c +++ b/arch/powerpc/kernel/watchdog.c @@ -59,7 +59,7 @@ static DEFINE_PER_CPU(u64, wd_timer_tb); * This will work best with NMI IPIs for crash code so the stuck CPUs * can be pulled out to get their backtraces. */ -static unsigned long __wd_smp_lock = 0; +static unsigned long __wd_smp_lock; static cpumask_t wd_smp_cpus_pending; static cpumask_t wd_smp_cpus_stuck; static u64 wd_smp_last_reset_tb; @@ -359,7 +359,7 @@ static int __init powerpc_watchdog_init(void) err = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "powerpc/watchdog:online", start_wd_on_cpu, stop_wd_on_cpu); if (err < 0) - pr_warning("Watchdog could not be initialized"); + pr_warn("Watchdog could not be initialized"); return 0; }