Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: round fluid values in log messages #276

Open
nicolas-lang opened this issue Nov 7, 2021 · 4 comments
Open

Enhancement: round fluid values in log messages #276

nicolas-lang opened this issue Nov 7, 2021 · 4 comments
Assignees

Comments

@nicolas-lang
Copy link

image

@nicolas-lang nicolas-lang changed the title Enhancement round fluid values in log messages Enhancement: round fluid values in log messages Nov 7, 2021
@nicolas-lang
Copy link
Author

nicolas-lang commented Nov 7, 2021

Hi,
while it is only a minor inconvenience I think it might be a nice improvement to slightly round the fluid values being displayed in the LTN messages.

(not sure why there is the bug label, it was not my intention to raise this as a bug, sorry)

@0ptera 0ptera added enhancement and removed bug labels Nov 7, 2021
@0ptera
Copy link
Owner

0ptera commented Nov 14, 2021

Would require either:

  1. rounding fluid values internally
  2. printing different messages for fluids and items

Neither option seems worth it to me.

@nicolas-lang
Copy link
Author

nicolas-lang commented Nov 14, 2021

I understand that you would consider additional logic just to get this done "not worth it" and I agree 100%.

From my perspective I can't think of any situations were it would be an issue to just round all the numbers in the "itemcount itemtype" part.
--> rounding fluids values: intended
--> rounding item counts: rounding an integer has no effect
--> rounding item stack counts: I don't know if LTN even even supports delivering 3.74 stacks, but I don't see any harm rounding the displayed value to 2 decimals.

This would meant that there is no "additional logic" required, just an additional ceil(...) where the info message is generated.

( P.S. this is very low priority for sure. )

@danbopes
Copy link

danbopes commented Feb 8, 2022

I too found the weird decimal point cluttering to my UI, and actively searched to try and find a setting to round these numbers to no avail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants