Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for fan light colour temperature #183

Closed
acal11 opened this issue Dec 29, 2022 · 5 comments · Fixed by #184
Closed

Support for fan light colour temperature #183

acal11 opened this issue Dec 29, 2022 · 5 comments · Fixed by #184
Labels
enhancement New feature or request
Milestone
1.7.0

Comments

@acal11
Copy link

acal11 commented Dec 29, 2022

It would be great if the FanAccessory could have support for COLOR_TEMP as the LightAccessory does.
The fan in question has temp_value as the DP for the colour temp.
@acal11 acal11 added the enhancement New feature or request label Dec 29, 2022
@0x5e
Copy link
Owner

0x5e commented Dec 29, 2022

Sure, I'm planning to modify the code of the lightbulb's part, make it reusable, then will be used in other categorys like fan, diffuser and so on.

@0x5e 0x5e added this to the 1.7.0 milestone Dec 29, 2022
@0x5e 0x5e linked a pull request Dec 29, 2022 that will close this issue
Reuse light characteristics. #184
Merged
@0x5e
Copy link
Owner

0x5e commented Dec 29, 2022

added in beta.18, please have a try.

@acal11
Copy link
Author

acal11 commented Dec 29, 2022

That was quick!

Unfortunately I get this error in the logs now when it launches:
7B9B6FA4-D3B1-4D15-9D25-E569AB6D166C

@0x5e
Copy link
Owner

0x5e commented Dec 30, 2022

Fixed in beta.19, I'm not at home and commit with other people's computer, please help me confirm if it's fixed, thanks.

@acal11
Copy link
Author

acal11 commented Dec 30, 2022

Looks to be working now! Many thanks

@acal11 acal11 closed this as completed Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Reuse light characteristics. 0x5e/homebridge-tuya-platform
2 participants
@0x5e @acal11