Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enableDataDogProfiler() err check is wrong #2201

Open
R-Santev opened this issue Aug 2, 2024 · 1 comment
Open

enableDataDogProfiler() err check is wrong #2201

R-Santev opened this issue Aug 2, 2024 · 1 comment

Comments

@R-Santev
Copy link

R-Santev commented Aug 2, 2024

enableDataDogProfiler() err check is wrong

Description

A wrong variable is checked for error is made in server/server.go:175
image

Your environment

  • OS and version.
    Irrelevant.
  • The version of the Polygon Edge.
    Version 1.3.3
  • The branch that causes this issue.
    develop
  • Locally or Cloud hosted (which provider).
    Irrelevant.
  • Please confirm if the validators are running under containerized environment (K8s, Docker, etc.).
    Irrelevant.

Expected behavior

  • Tell us what should happen.
    " DataDog profiler setup failed" must be logged when ddErr is != nil
  • Tell us what happened instead.
    It doesn't enter the if statement

Proposed solution

I am attaching a PR resolving the issue: #2200

@Faiqonli
Copy link

server/server.go:175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants