Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workers from proxy config file #1008

Closed
SantiagoPittella opened this issue Dec 9, 2024 · 1 comment
Closed

Remove workers from proxy config file #1008

SantiagoPittella opened this issue Dec 9, 2024 · 1 comment
Assignees
Milestone

Comments

@SantiagoPittella
Copy link
Collaborator

SantiagoPittella commented Dec 9, 2024

What should be done?

The proxy should receive the workers through the start-proxy CLI command as a parameter

How should it be done?

  • Remove the worker list from the configuration file.
  • Add a parameter to the start-proxy command to declare the workers.

When is this task done?

The task is done when we don't persist the workers anymore.

Additional context

No response

@SantiagoPittella SantiagoPittella changed the title Remove proxy config file Remove workers from proxy config file Dec 9, 2024
@bobbinth
Copy link
Contributor

bobbinth commented Dec 9, 2024

I was actually thinking that we'd keep the config file but take the list of workers out of it since this part seems to be pretty dynamic.

We could also do a combination of strategies - i.e., CLI params override the config file. But either way, I'd remove the list of workers from the config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants