Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests in miden-vm package are not running #1501

Open
yasonk opened this issue Sep 17, 2024 · 0 comments
Open

Unit tests in miden-vm package are not running #1501

yasonk opened this issue Sep 17, 2024 · 0 comments

Comments

@yasonk
Copy link
Contributor

yasonk commented Sep 17, 2024

When running make test unit tests in the miden-vm package are not running.
For example:

#[cfg(test)]

#[cfg(test)]

Here are some potential issues that don't seem to enable running the tests anyway:

  1. Adding testing = [] to Cargo.toml
  2. Renaming mod test to mod tests.

Adding unit tests to different crates of the miden-vm package also results in tests not getting run by make test.

I'm able to run the tests (when run some of the tests fail):

cargo test --package miden-vm --bin miden --features executable --  --show-output 

Should this be fixed by adding "executable" feature to make test, because it looks like the tests are skipped because the required-features in miden/Cargo.toml file lists "executable" in the [[bin]] section?

@yasonk yasonk mentioned this issue Sep 17, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant