We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
circuit_builder
Hey guys!
In plonky2/src/plonk/circuit_builder.rs there is enabled import then feature timing is activated:
plonky2/src/plonk/circuit_builder.rs
timing
#[cfg(feature = "timing")] use web_time::Instant;
after that, there is something following:
#[cfg(feature = "std")] let start = Instant::now();
This breaks compilation, if try to add plonky2 with only std feature:
std
[dependencies] plonky2 = { version = "1.0.0", default-features = false, features = ["std"] }
since rust can't find Instant type (being unimported because I didn't enable timing)
Instant
I guess at the second code snippet shall be conditional for timing and not std, like:
#[cfg(feature = "timing")] let start = Instant::now();
or maybe conditional import from std, if timing is disabled
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Hey guys!
In
plonky2/src/plonk/circuit_builder.rs
there is enabled import then featuretiming
is activated:after that, there is something following:
This breaks compilation, if try to add plonky2 with only
std
feature:since rust can't find
Instant
type (being unimported because I didn't enabletiming
)I guess at the second code snippet shall be conditional for
timing
and notstd
, like:or maybe conditional import from std, if
timing
is disabledThe text was updated successfully, but these errors were encountered: