You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
RPC nodes are precious - we don't like to expose them, and using them in CI means we have to be more careful about that.
We can't/don't want to spin up an RPC node in CI.
We don't want to mock a whole RPC node.
Why not? We have already done that with the real node here, and here is the regression test that was missing for your usecase.
That aside, I agree that we should discuss functionality split.
EDIT: we now use kurtosis, before we used docker-compose to spin up test network for real regression test.
In #375 (comment), I make the broad suggestion to decompose our "cleverer" functionality into simpler commands, e.g splitting:
In #413 I regressed functionality that we don't test in CI - talking to RPC nodes and assembling an output.
This is hard to test in CI because:
However, because this part of
trace_decoder/zero_bin
is all bundled together, we can't catch regressions without solving some of the above.We can break out our Public API, and get benefits in:
at relatively low UX cost.
The text was updated successfully, but these errors were encountered: