From dbd68a35e594b7b6451595af83fc841dff134172 Mon Sep 17 00:00:00 2001
From: amar-1995 <amar@100ms.live>
Date: Fri, 18 Aug 2023 20:12:58 +0530
Subject: [PATCH] fix: remove resolution popup

---
 .../components/Header/StreamActions.jsx       | 93 +++++++------------
 1 file changed, 33 insertions(+), 60 deletions(-)

diff --git a/packages/roomkit-react/src/Prebuilt/components/Header/StreamActions.jsx b/packages/roomkit-react/src/Prebuilt/components/Header/StreamActions.jsx
index ca6faeb784..51d44b140d 100644
--- a/packages/roomkit-react/src/Prebuilt/components/Header/StreamActions.jsx
+++ b/packages/roomkit-react/src/Prebuilt/components/Header/StreamActions.jsx
@@ -13,13 +13,11 @@ import {
 import { AlertTriangleIcon, CrossIcon, RecordIcon } from '@100mslive/react-icons';
 import { Box, Button, config as cssConfig, Flex, HorizontalDivider, Loading, Popover, Text, Tooltip } from '../../../';
 import { Sheet } from '../../../Sheet';
-import { ResolutionInput } from '../Streaming/ResolutionInput';
-import { getResolution } from '../Streaming/RTMPStreaming';
 import { ToastManager } from '../Toast/ToastManager';
 import { AdditionalRoomState, getRecordingText } from './AdditionalRoomState';
 import { useSetAppDataByKey } from '../AppData/useUISettings';
 import { formatTime } from '../../common/utils';
-import { APP_DATA, RTMP_RECORD_DEFAULT_RESOLUTION } from '../../common/constants';
+import { APP_DATA } from '../../common/constants';
 
 export const LiveStatus = () => {
   const { isHLSRunning, isRTMPRunning } = useRecordingStreaming();
@@ -112,7 +110,6 @@ export const RecordingStatus = () => {
 
 const StartRecording = () => {
   const permissions = useHMSStore(selectPermissions);
-  const [resolution, setResolution] = useState(RTMP_RECORD_DEFAULT_RESOLUTION);
   const [open, setOpen] = useState(false);
   const [recordingStarted, setRecordingState] = useSetAppDataByKey(APP_DATA.recordingStarted);
   const { isBrowserRecordingOn, isStreamingOn, isHLSRunning } = useRecordingStreaming();
@@ -161,62 +158,38 @@ const StartRecording = () => {
     );
   }
   return (
-    <Popover.Root open={open} onOpenChange={setOpen}>
-      <Popover.Trigger asChild>
-        <Button
-          data-testid="start_recording"
-          variant="standard"
-          icon
-          disabled={recordingStarted || isStreamingOn}
-          onClick={() => setOpen(true)}
-        >
-          {recordingStarted ? <Loading size={24} color="currentColor" /> : <RecordIcon />}
-          <Text as="span" css={{ '@md': { display: 'none' }, color: 'currentColor' }}>
-            {recordingStarted ? 'Starting' : 'Start'} Recording
-          </Text>
-        </Button>
-      </Popover.Trigger>
-      <Popover.Content align="end" sideOffset={8} css={{ w: '$64' }}>
-        <ResolutionInput
-          testId="recording_resolution"
-          css={{ flexDirection: 'column', alignItems: 'start' }}
-          onResolutionChange={setResolution}
-        />
-        <Button
-          data-testid="start_recording_confirm"
-          variant="primary"
-          icon
-          css={{ ml: 'auto' }}
-          type="submit"
-          disabled={recordingStarted || isStreamingOn}
-          onClick={async () => {
-            try {
-              setRecordingState(true);
-              await hmsActions.startRTMPOrRecording({
-                resolution: getResolution(resolution),
-                record: true,
-              });
-            } catch (error) {
-              if (error.message.includes('stream already running')) {
-                ToastManager.addToast({
-                  title: 'Recording already running',
-                  variant: 'error',
-                });
-              } else {
-                ToastManager.addToast({
-                  title: error.message,
-                  variant: 'error',
-                });
-              }
-              setRecordingState(false);
-            }
-            setOpen(false);
-          }}
-        >
-          Start
-        </Button>
-      </Popover.Content>
-    </Popover.Root>
+    <Button
+      data-testid="start_recording"
+      variant="standard"
+      icon
+      disabled={recordingStarted || isStreamingOn}
+      onClick={async () => {
+        try {
+          setRecordingState(true);
+          await hmsActions.startRTMPOrRecording({
+            record: true,
+          });
+        } catch (error) {
+          if (error.message.includes('stream already running')) {
+            ToastManager.addToast({
+              title: 'Recording already running',
+              variant: 'error',
+            });
+          } else {
+            ToastManager.addToast({
+              title: error.message,
+              variant: 'error',
+            });
+          }
+          setRecordingState(false);
+        }
+      }}
+    >
+      {recordingStarted ? <Loading size={24} color="currentColor" /> : <RecordIcon />}
+      <Text as="span" css={{ '@md': { display: 'none' }, color: 'currentColor' }}>
+        {recordingStarted ? 'Starting' : 'Start'} Recording
+      </Text>
+    </Button>
   );
 };