Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eleventy advises using debug output when in debug mode. #224

Closed
edwardhorsford opened this issue Sep 12, 2018 · 3 comments
Closed

Eleventy advises using debug output when in debug mode. #224

edwardhorsford opened this issue Sep 12, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@edwardhorsford
Copy link
Contributor

edwardhorsford commented Sep 12, 2018

I have some kind of issue with my templates causing a render error.

Eleventy advises using debug mode even though I'm already using debug mode. I presume it shouldn't give this advice when in debug mode.
screen shot 2018-09-12 at 13 00 31


As an aside - the output can be hard to skim to work out which file has the issue. Most of the errors spat out refer to node modules, rather than the likely culprit files. In this case, it took quite a long time to work out what was wrong as the actual file with the issue isn't stated. All it tells me is it's line 3 of some file. I went through all recently changed files moving the lines down by one to work out which file was causing the crash.

@zachleat
Copy link
Member

Fair point! Some of the error reporting stuff has been already reworked and improved in 0.5.4 but I’m sure it still says this 😎

The debug output tries to give as much information as possible for both you and I to debug the situation. That means that yes, the debug output will spit ugly stack traces—maybe not super helpful to you but they’re necessary.

Hopefully it will read a little better in the next version, we can revisit discussion after that’s released.

@mathiasbynens
Copy link

I think @edwardhorsford was referring to the (more info in DEBUG output) part of the output. This is printed even when in DEBUG mode.

@zachleat zachleat added this to the 0.5.4 milestone Sep 13, 2018
@zachleat zachleat added the bug label Sep 13, 2018
@zachleat zachleat self-assigned this Sep 13, 2018
@zachleat
Copy link
Member

Pushed some code to fix this specific issue. Please reopen a new issue if you see additional problems with error reporting after 0.5.4 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants