-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
Hmm. Maybe I should change this to be a Windows batch script that can just take in the EmojiOne and Segue UI fonts? So a user wouldn't have to attempt to use the build system on Windows. |
@@ -0,0 +1,54 @@ | |||
#!/usr/bin/env python2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the license on this code? Did you write all of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used this sample script in font tools as inspiration. It's under an MIT style license as well, however I'm not sure what the guideline is for attribution here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behdad Esfahbod wrote it. So, I'd add a copy of the MIT license copyright him.
Thanks for a great PR! Even followed my git commit message standard 😍
Yes, I think so. The overall build doesn't run on Windows. Right now I am thinking it would be best as a batch file in a |
Could you rebase this into one commit and force push to this branch? It'll be something like:
|
This will need install directions added to the README. What versions of Windows does this support? 8 and 10? |
I meant to push this to a -wip branch so it wouldn't hit the PR yet. Will do on the squashing. I'm downloading Microsoft's testing VM to try this on 8 and 10, since I only use 7. I think I might have to edit it a bit because I think they use a different font name. I'll add to the README once I know that's settled. |
126e06a
to
27647ce
Compare
Tested on both 8 and 10. On those versions, both the Emoji and the Symbol font need to be replaced. Also updated the README. |
from: https://github.com/eosrei/emojione-color-font/releases | ||
|
||
Help wanted: [How to override the Windows default Segoe UI Emoji font][16] | ||
There are two install options for OS X. Both SVGinOT versions are available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OS X
;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! Fixed.
I'll test this later this week. Thank you for your work on it! 😉 |
Just found this. You might have made a solution ;) http://superuser.com/questions/1062418/how-do-i-replace-windows-10s-emoji |
Building the V1.3 packages right now... |
REM Merge Segoe UI Symbol into EmojiOne, this keeps emoji one's glyph ids intact | ||
REM for the 'SVG ' table data | ||
pyftmerge %EMOJI_FONT_PATH% %MS_FONT_PATH% | ||
REM pyftmerge doesn't generate a cmap4 table if either font has a cmap12 table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we can fix this in SCFBuild?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually fixed this in FontTools, so it will be in whatever their next release is. The emoji font has the correct tables, it was FontTool's fault that the merge was incorrect. That's what the python script corrects, and what my PR for them fixed.
|
I'm using Windows for the first time this year. What have you done to me ?!?! Haha! 😲 I removed all the old installs of everything in Win10. Then:
Adding We need this to work "out of the box". Step by step for the non-experienced user. Can you add more details to the install process in the README.md? I'd recommend Chocolatey to get people using it. Side note: Powershell is so slow. Just typing |
Ahhh. I installed python using the installer from python.org. That's really unfortunate the Chocolatey package does not include the scripts folder in the path. Would you recommend just ensuring those directions in the README or try to handle some of these different cases in the script? |
I'll uninstall and try it again with the python.org installer. Chocolatey just runs the installer, it shouldn't make a difference. |
I setup a fresh win10 VM (https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/) and installed the current Python 2.7 from python.org. I found the cause of this problem: I've discovered Chocolatey will set the path correctly if the
I'm trying to figure out a long term straightforward solution for this. I've looked PyInstaller, but that seems overkill. I tested installing Fonttools from git:
It gets the current repo version which has your fixes We could avoid packaging the This is all just notes. Nothing actionable. Solution? Best thing right now is a step-by-step install process. The Linux manual install process, for example, includes everything needed. It's just a copy/paste. We need something similar for Windows. Thanks for your work on this! I need this entire process tested, documented and polished since I need to support this going forward. Thanks for understanding 😄 |
I totally understand. Time spent getting it right now, means less time dealing with users who don't get it right when trying to install. What about just having the script install the FontTools from git source and ensure the scripts directory is in the path? |
Yes. Sounds easier to maintain. It's possible to avoid a dependency on git.:
Yes. It could be temporarily added. Rough draft of instructions:
Still so complex... |
I don't think it's necessary to run an Administrator command prompt. The font viewer should have a little admin permission request box when attempting to install fonts. |
Oh good point. I was thinking it was needed for pip, but no. |
Okay, I'll edit the script to temporarily set the PATH variable, and run the |
I can tackle this tomorrow. Things have been busy, and I want to test and make sure it will work the correctly. :) |
Ugh. So, unfortunately, a foolproof way of determining where python is installed if it is not on the PATH is not easy, but it is completely outlined in PEP 514. There is a small app that we could bundle (created by python devs and BSD 2-clause licensed) to do this work for us of determining the install location. However, I think this is a bit overkill, but doing the search in the install script will also be very difficult, and not pretty looking at all. It might just make more sense to check if python is available on the PATH, and if it isn't, instruct the user to add it to the PATH (as a message in the install script when it exits on error). Suggestions? |
In Windows 10: I've tried installing Python2 via Chocolately and the installer, then Python3 via Chocolately and the the installer. Chocolately with Python3 gets close to useful. The best option is Python 3 with the regular installer. The user needs to specifically check the install to path, then Having Python and Pip in the path should be a hard requirement.
The instructions would say to install the most recent Python3, then Edit: |
Second draft of instructions:
|
Install script now checks for python and pip, then installs the master.zip of FontTools. Removed the cmap script now that we no longer need it. Updated the README |
|
||
ECHO Ensuring the latest FontTools is installed. | ||
|
||
pip install --upgrade https://github.com/behdad/fonttools/archive/master.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a call to WHERE
for ttx
? Might as well just check that after the fonttools
install, confirms everything is working.
Otherwise this is looking really good! Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'll rebuild everything and check it tonight on Win10
Adds an install process to replace Emoji on Windows. It merges the EmojiOne font with Segoe UI Symbol on the user's machine, and replaces Segoe UI Emoji as well on Win 8 and 10. An uninstall script is also included to assist the user in restoring the original Windows fonts. README also updated. Fixes 13rac1#15
I've tested install and uninstall in Windows 10. Everything seems to be working, even the new power symbols! ⏻ ⏼ ⏽ ⭘ ⏾ I'm happy to merge this as-is now. 😄 Great work! Separate/additional questions:
|
Hmm. Yeah, that should work. Both the VBS and PS method should work fine. For eosrei/twemoji-color-font, can you make an issue and assign it to me? I can handle it, but it might be in a week or two (or this week if I'm lucky). |
Cool! I didn't want to wait any longer! https://github.com/eosrei/emojione-color-font/releases/tag/v1.3 |
This requires the builder to supply a Segoe UI Symbol input font
and will merge the regular font with the input font.
For #15