Fix compilation on fresh installs

[vadimavdeev]

Local builds no longer work because esbuild has been upgraded to a backward-incompatible version. This PR updates compile.ts script to use the newer esbuild APIs. One difference between this and the previous version is that console.log('[${name}] build succeeded') will be called for every build, not only in watch mode.

Fixes #154

[jodyheavener]

Hey @vadimavdeev, thanks so much for uncovering and open a PR for this issue! I just tried to give it a spin and it appears I'm still getting an error (using yarn build and yarn watch):

$ node -r esbuild-register compile.ts
✘ [ERROR] Invalid option in context() call: "watch"

    /Repositories/op-vscode/node_modules/esbuild/lib/main.js:255:12:
      255 │       throw new Error(`Invalid option ${where}: ${quote(key)}`);
          ╵             ^

    at checkForInvalidFlags (/Repositories/op-vscode/node_modules/esbuild/lib/main.js:255:13)
    at flagsForBuildOptions (/Repositories/op-vscode/node_modules/esbuild/lib/main.js:457:3)
    at buildOrContextContinue (/Repositories/op-vscode/node_modules/esbuild/lib/main.js:1009:9)
    at /Repositories/op-vscode/node_modules/esbuild/lib/main.js:983:11
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

I'll be happy to take a closer look at this during my next cycle, but I wanted to raise in case you had any ideas. Are you also experiencing this?

[vadimavdeev]

Hey @vadimavdeev, thanks so much for uncovering and open a PR for this issue! I just tried to give it a spin and it appears I'm still getting an error (using yarn build and yarn watch):

$ node -r esbuild-register compile.ts
✘ [ERROR] Invalid option in context() call: "watch"

    /Repositories/op-vscode/node_modules/esbuild/lib/main.js:255:12:
      255 │       throw new Error(`Invalid option ${where}: ${quote(key)}`);
          ╵             ^

    at checkForInvalidFlags (/Repositories/op-vscode/node_modules/esbuild/lib/main.js:255:13)
    at flagsForBuildOptions (/Repositories/op-vscode/node_modules/esbuild/lib/main.js:457:3)
    at buildOrContextContinue (/Repositories/op-vscode/node_modules/esbuild/lib/main.js:1009:9)
    at /Repositories/op-vscode/node_modules/esbuild/lib/main.js:983:11
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

I'll be happy to take a closer look at this during my next cycle, but I wanted to raise in case you had any ideas. Are you also experiencing this?

Yep, my bad. watch: true slipped through when I tested the error handling code I put back. Should be fine now. Could you check again?

[jodyheavener]

That did it!

[jodyheavener]

Ah - apologies, commits going into main need to be signed. Possible for you to squash this work and sign the commit? If you're new to commit signing we've made it real easy to get set up 😏

[vadimavdeev]

Ah - apologies, commits going into main need to be signed. Possible for you to squash this work and sign the commit? If you're new to commit signing we've made it real easy to get set up 😏

Sure, let me do that.

[vadimavdeev]

Done. It was real easy indeed. 1Password's docs are excellent.

[jodyheavener]

Awesome, thank you so much for fixing this!