Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin refactoring prefinal #33

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Plugin refactoring prefinal #33

merged 7 commits into from
Mar 29, 2024

Conversation

alxart
Copy link
Contributor

@alxart alxart commented Mar 27, 2024 •
edited
Loading

  • Сверил внешний интерфейс старого и нового плагинов, написал reference.
  • Починил тесты.
  • Допилил логику setState при асинхронном поведении (dontWaitAll).
  • Допилил пои для этажей (завел доп. задачи на доделку).
  • Допилил методы destroy для плагина и realtyScene.
  • Допилил ховер моделей.

alxart
alxart commented Mar 28, 2024
View reviewed changes
src/types/plugin.ts Outdated Show resolved Hide resolved
kalyanov
kalyanov reviewed Mar 28, 2024
View reviewed changes
src/labelGroups.ts Outdated Show resolved Hide resolved
src/types/events.ts Show resolved Hide resolved
@alxart alxart merged commit 2f13748 into plugin-refactoring Mar 29, 2024
3 checks passed
@alxart alxart mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalyanov kalyanov kalyanov approved these changes

@Farfurix Farfurix Farfurix approved these changes

@iv-berezin iv-berezin Awaiting requested review from iv-berezin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alxart @kalyanov @Farfurix