Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(preprocessing): better performance #12

Merged
merged 11 commits into from
Mar 19, 2023
Merged

perf(preprocessing): better performance #12

merged 11 commits into from
Mar 19, 2023

Conversation

34j
Copy link
Collaborator

@34j 34j commented Mar 19, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2023

Codecov Report

Merging #12 (13c186f) into main (a822a60) will increase coverage by 0.08%.
The diff coverage is 23.25%.

❗ Current head 13c186f differs from pull request most recent head 7755c7b. Consider uploading reports for the commit 7755c7b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   17.28%   17.36%   +0.08%     
==========================================
  Files          28       28              
  Lines        3142     3150       +8     
  Branches      340      311      -29     
==========================================
+ Hits          543      547       +4     
- Misses       2589     2600      +11     
+ Partials       10        3       -7     
Impacted Files Coverage Δ
src/so_vits_svc_fork/__main__.py 0.00% <0.00%> (ø)
src/so_vits_svc_fork/preprocess_flist_config.py 90.41% <ø> (ø)
src/so_vits_svc_fork/preprocess_hubert_f0.py 35.55% <12.00%> (+3.73%) ⬆️
src/so_vits_svc_fork/utils.py 18.91% <33.33%> (-0.07%) ⬇️
src/so_vits_svc_fork/preprocess_resample.py 63.63% <50.00%> (-6.74%) ⬇️
src/so_vits_svc_fork/__init__.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@34j 34j merged commit 668c8e1 into main Mar 19, 2023
@34j 34j deleted the preprocess_tweaks branch March 19, 2023 04:17
@34j
Copy link
Collaborator Author

34j commented Mar 19, 2023

@allcontributors GarrettConway code

@allcontributors
Copy link
Contributor

@34j

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@34j
Copy link
Collaborator Author

34j commented Mar 19, 2023

@allcontributors add GarrettConway code

@allcontributors
Copy link
Contributor

@34j

I've put up a pull request to add @GarrettConway! 🎉

@34j
Copy link
Collaborator Author

34j commented Mar 19, 2023

@allcontributors add 34j example, infra, maintenance, review, test, tutorial, promotion, bug

@allcontributors
Copy link
Contributor

@34j

I've put up a pull request to add @34j! 🎉

np.save(f0_path, f0)
else:
LOG.info(f"Skip {filepath} because {f0_path} exists.")
torch.cuda.empty_cache()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you for finding that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants