fix: remove possible leak in unused code #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #203 +/- ##
=======================================
Coverage 19.93% 19.93%
=======================================
Files 38 38
Lines 3241 3241
Branches 410 410
=======================================
Hits 646 646
Misses 2579 2579
Partials 16 16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BlueAmulet
force-pushed
the
fix/unused_leak
branch
from
9deb58b to
326b45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing every actually sets RealtimeVC.split to False so this section of code goes unused, but this piece of code has a potential leak issue. If the audio is quiet enough to be considered silence, it just pumps the original audio through instead of outputting true silence. If this happens to be a silence misdetection then you possible leak the users' original voice.