Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: move methods from dataloader to pre-hubert #218

Merged
merged 14 commits into from
Apr 4, 2023
Merged

perf: move methods from dataloader to pre-hubert #218

merged 14 commits into from
Apr 4, 2023

Conversation

34j
Copy link
Collaborator

@34j 34j commented Apr 3, 2023

Closes #217, Closes #223

@34j
Copy link
Collaborator Author

34j commented Apr 3, 2023

I haven't verified that the outputs match at all

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Merging #218 (e3254a5) into main (e921c3d) will increase coverage by 0.09%.
The diff coverage is 19.65%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   19.96%   20.06%   +0.09%     
==========================================
  Files          38       38              
  Lines        3235     3210      -25     
  Branches      409      416       +7     
==========================================
- Hits          646      644       -2     
+ Misses       2573     2551      -22     
+ Partials       16       15       -1     
Impacted Files Coverage Δ
src/so_vits_svc_fork/train.py 18.85% <11.11%> (+0.77%) ⬆️
src/so_vits_svc_fork/utils.py 19.71% <13.33%> (-1.31%) ⬇️
...its_svc_fork/preprocessing/preprocess_hubert_f0.py 35.29% <16.12%> (-3.17%) ⬇️
src/so_vits_svc_fork/modules/mel_processing.py 19.73% <16.66%> (-4.86%) ⬇️
src/so_vits_svc_fork/data_utils.py 31.25% <25.58%> (+12.36%) ⬆️
src/so_vits_svc_fork/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@34j
Copy link
Collaborator Author

34j commented Apr 3, 2023

Comment out and roll back changes because of incompatibility...

@34j 34j force-pushed the perf/dataloader branch from eea693e to 78c2d95 Compare April 3, 2023 14:56
@34j 34j added the help wanted Extra attention is needed label Apr 3, 2023
self, batch: Sequence[dict[str, torch.Tensor]]
) -> tuple[torch.Tensor, ...]:
batch = [b for b in batch if b is not None]
lengths = torch.tensor([b["mel_spec"].shape[1] for b in batch]).long()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug

@34j 34j removed the help wanted Extra attention is needed label Apr 4, 2023
@34j 34j merged commit d5a4456 into main Apr 4, 2023
@34j 34j deleted the perf/dataloader branch April 4, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to run this using JupyterLab but receive error Move methods from dataloader to pre-hubert
2 participants