Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cookiejar synchronous functions by default #107

Merged
merged 10 commits into from
May 7, 2022

Conversation

3846masa
Copy link
Owner

@3846masa 3846masa commented May 7, 2022

BREAKING CHANGE: The property name for passing cookiejar to agent has been changed.

BREAKING CHANGE: Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, pass cookies.async_UNSTABLE to true.

@3846masa 3846masa changed the title feat: use sync function in cookiejar by default feat: use cookiejar synchronous functions by default May 7, 2022
@3846masa 3846masa merged commit 2c4c0f8 into develop May 7, 2022
@3846masa 3846masa deleted the feat/unstable-async branch May 7, 2022 14:42
3846masa added a commit that referenced this pull request May 7, 2022
BREAKING CHANGE: The property name for passing cookiejar to agent has been changed.

BREAKING CHANGE: Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, pass cookies.async_UNSTABLE to true.
3846masa added a commit that referenced this pull request May 7, 2022
BREAKING CHANGE: The property name for passing cookiejar to agent has been changed.

BREAKING CHANGE: Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, pass cookies.async_UNSTABLE to true.
3846masa added a commit that referenced this pull request May 7, 2022
BREAKING CHANGE: The property name for passing cookiejar to agent has been changed.

BREAKING CHANGE: Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, pass cookies.async_UNSTABLE to true.
3846masa added a commit that referenced this pull request May 7, 2022
BREAKING CHANGE: The property name for passing cookiejar to agent has been changed.

BREAKING CHANGE: Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, set cookies.async_UNSTABLE to true.
github-actions bot pushed a commit that referenced this pull request May 7, 2022
# [3.0.0](v2.1.2...v3.0.0) (2022-05-07)

### Features

* change import path for node:http ([#105](#105)) ([6260bdc](6260bdc))
* update README and add MIGRATION GUIDES ([#110](#110)) ([cb03a9f](cb03a9f))
* use cookiejar synchronous functions by default ([#107](#107)) ([2bf68bb](2bf68bb))

### BREAKING CHANGES

* see MIGRATION.md for more details.
* The property name for passing cookiejar to agent has been changed.
* Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, set cookies.async_UNSTABLE to true.
* you should import `'http-cookie-agent/node:http'` instead of `'http-cookie-agent'`.
3846masa pushed a commit that referenced this pull request May 8, 2022
# [3.0.0](v2.1.2...v3.0.0) (2022-05-07)

### Features

* change import path for node:http ([#105](#105)) ([6260bdc](6260bdc))
* update README and add MIGRATION GUIDES ([#110](#110)) ([cb03a9f](cb03a9f))
* use cookiejar synchronous functions by default ([#107](#107)) ([2bf68bb](2bf68bb))

### BREAKING CHANGES

* see MIGRATION.md for more details.
* The property name for passing cookiejar to agent has been changed.
* Changed to use cookiejar synchronous functions by default. If you use an asynchronous cookiejar store, set cookies.async_UNSTABLE to true.
* you should import `'http-cookie-agent/node:http'` instead of `'http-cookie-agent'`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant