Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P_???_0321_01 seems incorrect #76

Open
jordig100 opened this issue Dec 15, 2022 · 1 comment
Open

P_???_0321_01 seems incorrect #76

jordig100 opened this issue Dec 15, 2022 · 1 comment
Assignees

Comments

@jordig100
Copy link
Collaborator

jordig100 commented Dec 15, 2022

The P_???_321_01.3mf files, seems to be incorrect.

3MF Builder, Magics, and Netfabb show it as inverted normals:
image

On the other hand it contains the -1 in the transform with make it a negative determinant. This is forbidden in latest core spec version: https://github.com/3MFConsortium/spec_core/blob/master/3MF%20Core%20Specification.md#33-3d-matrices

However if we pace a 1 instead of the -1 in the transform, the applications still complain about it.

This seems to be a case for a negative test case.

In Test suite revision 1.34:
Fixes for GitHub Test_Suite issues 65, 66. Modified positive test cases 321_01, 506_01, 304_04, and added negative test case 405_04.

But the test case 321_01 seems to be the same. Not sure what happens to the other test files.

Please verify.

@JimZuber
Copy link
Collaborator

Yes, recent changes to the core specification disallowing negative determinant invalidate this test case. I moved this positive test case (P_???0321_01) to a negative test case (N???_416_03). The test specification and suites 1 through 6 have been updated on the develop branch. @jordi, I will let you close this issue assuming you are happy with the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants