Skip to content
This repository has been archived by the owner on Aug 9, 2021. It is now read-only.

Store node keys in key service/layer instead of in IPFS repo #77

Closed
zachferland opened this issue Feb 27, 2019 · 3 comments
Closed

Store node keys in key service/layer instead of in IPFS repo #77

zachferland opened this issue Feb 27, 2019 · 3 comments
Assignees

Comments

@zachferland
Copy link
Contributor

Root store in ipfs repo includes, configs include keys. We likely want to move these keys into a more clearly permissioned layer vs s3 layer which may have more open permissions.

@zachferland zachferland added this to the Sprint 15 milestone Feb 27, 2019
@oed
Copy link
Member

oed commented Feb 27, 2019

Maybe store it encrypted by KMS similar to what we do with the serverless functions?

@zachferland
Copy link
Contributor Author

More details and summary of convo with @lsenta

In the ipfs js client keys are in the 'root' repo/store which includes configs files and some extra metadata. The keys are stored in the config file at the moment. Basically if we just load and pass the keys on start they are still going to end up there (same place they are now). What the go ipfs client does is better, the keys are a in the 'keys' repo/store which stores key files. So an actual implementation would be creating a keys store that loads the keys when needed. The keys repo is just empty in the js client at the moment. You can technically create a custom root store that stores configs in places and keys in another, but not worth the effort at the moment.

Would likely say we can hold on this for now

@laurentsenta
Copy link
Contributor

The related issue in js-ipfs: ipfs/js-ipfs#1138

+1 to hold and revist this in a few weeks and / or when the github issue is fixed.

@michaelsena michaelsena removed this from the Sprint 15 milestone Mar 11, 2019
@dazuck dazuck closed this as completed Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants