Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower:resolve task fail when component's name contains ".css" #55

Merged
merged 1 commit into from
Jan 3, 2014
Merged

Conversation

yujiym
Copy link
Contributor

@yujiym yujiym commented Jan 3, 2014

bower:resolve task fail when component's name contains ".css"
('animate.css', 'hint.css', ...)

rake aborted!
Is a directory @ io_fread - bower_components/hint.css

I patched FileTest.file? to skip that case, but I think there is a more smarter approach.

Component’s name like “animate.css”, “hint.css”,,,
matched Dir['bower_components/**/*.css’]
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3a8836d on yujiym:patch into 8b81ff7 on 42dev:master.

@rharriso
Copy link
Owner

rharriso commented Jan 3, 2014

Do you mean when a directory name contains .css?

@yujiym
Copy link
Contributor Author

yujiym commented Jan 3, 2014

@rharriso Exactly.

rharriso added a commit that referenced this pull request Jan 3, 2014
bower:resolve task fail when component's name contains ".css"
@rharriso rharriso merged commit 6b6c489 into rharriso:master Jan 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants