Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whatsapp add " (edited)" after the configured EditSuffix #1510

Closed
nathanaelhoun opened this issue Jun 5, 2021 · 0 comments
Closed

Whatsapp add " (edited)" after the configured EditSuffix #1510

nathanaelhoun opened this issue Jun 5, 2021 · 0 comments

Comments

@nathanaelhoun
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.
Matterbridge is always adding the " (edited)" suffix, even when EditSuffix is configured.

To Reproduce
Steps to reproduce the behavior:

  • Bridge whatsapp and another service which supports editing (like Mattermost, Discord)
  • Configure EditSuffix, either globally or for Whatsapp
  • Edit the message
  • See the problem

Expected behavior
A clear and concise description of what you expected to happen.
The string configured in EditSuffix should replace the " (edited)" suffix.

Screenshots/debug logs
If applicable, add screenshots to help explain your problem.
Use logs from running matterbridge -debug if possible.

image

Environment (please complete the following information):

  • OS: linux
  • Matterbridge version: version: 1.22.2 641ed18
  • If self compiled: output of git rev-parse HEAD

Additional context
Please add your configuration file (be sure to exclude or anonymize private data (tokens/passwords))

I wanted to PR this change 0303af4 but looking to the code, I think the string will be empty if EditSuffix is not configured, which may be a problem.

@42wim 42wim added the whatsapp label Jun 24, 2021
42wim added a commit that referenced this issue Feb 6, 2022
To keep it backwards compatible we keep the "(edited)" message when no
editsuffix is configured.
@42wim 42wim closed this as completed in 2a3f475 Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants