data race - discord

[dajohi]

[2019-04-26T23:14:42Z] ERROR matrix:       Content[body] is not a string: <nil>                                      
map[string]interface {}{}     
==================            
WARNING: DATA RACE            
Write at 0x00c0011bcd20 by goroutine 77:                    
  github.com/bwmarrin/discordgo.(*State).OnInterface()      
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/state.go:929 +0x1360                      
  github.com/bwmarrin/discordgo.(*Session).onInterface()    
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/event.go:236 +0x1be                       
  github.com/bwmarrin/discordgo.(*Session).handleEvent()    
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/event.go:194 +0x96                        
  github.com/bwmarrin/discordgo.(*Session).onEvent()        
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/wsapi.go:562 +0x18ce                      
  github.com/bwmarrin/discordgo.(*Session).listen()         
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/wsapi.go:251 +0xaf                        

Previous read at 0x00c0011bcd20 by goroutine 79:            
  github.com/42wim/matterbridge/bridge/discord.(*Bdiscord).memberAdd()                                               
      /home/matterbridge/.go/src/github.com/42wim/matterbridge/bridge/discord/handlers.go:135 +0xac                  
  github.com/42wim/matterbridge/bridge/discord.(*Bdiscord).memberAdd-fm()                                            
      /home/matterbridge/.go/src/github.com/42wim/matterbridge/bridge/discord/handlers.go:130 +0x55                  
  github.com/bwmarrin/discordgo.guildMemberAddEventHandler.Handle()                                                  
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/eventhandlers.go:317 +0x69                

Goroutine 77 (running) created at:                          
  github.com/bwmarrin/discordgo.(*Session).Open()           
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/wsapi.go:203 +0x1319                      
  github.com/bwmarrin/discordgo.(*Session).reconnect()      
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/wsapi.go:796 +0x128                       
  github.com/bwmarrin/discordgo.(*Session).listen()         
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/wsapi.go:239 +0x38b                       

Goroutine 79 (finished) created at:                         
  github.com/bwmarrin/discordgo.(*Session).handle()         
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/event.go:171 +0x1df                       
  github.com/bwmarrin/discordgo.(*Session).handleEvent()    
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/event.go:200 +0x103                       
  github.com/bwmarrin/discordgo.(*Session).onEvent()        
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/wsapi.go:562 +0x18ce                      
  github.com/bwmarrin/discordgo.(*Session).listen()         
      /home/matterbridge/.go/pkg/mod/github.com/bwmarrin/discordgo@v0.19.0/wsapi.go:251 +0xaf                        
==================  

[dajohi]

tagging @bwmarrin

[bwmarrin]

thanks for the ping @dajohi :) I'll see what I can find on my side.

[bwmarrin]

For the lazy, like me :)

Read at : https://github.com/42wim/matterbridge/blob/master/bridge/discord/handlers.go#L135
Write at : https://github.com/bwmarrin/discordgo/blob/master/state.go#L929

[dajohi]

@bwmarrin correct. So which discordgo API should be used for concurrent-safe reads?

[bwmarrin]

@dajohi they're using it just fine. It's a library issue that will need fixed on discordgo side.

[42wim]

Going to close this here, as it needs to be addressed upstream and is already an open issue there.