Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic plot improvement #18

Closed
444B opened this issue Mar 2, 2024 · 2 comments
Closed

Traffic plot improvement #18

444B opened this issue Mar 2, 2024 · 2 comments
Assignees
Labels
bug Something isn't working future release The issue will be fixed in a future release

Comments

@444B
Copy link
Owner

444B commented Mar 2, 2024

Original issue by mateusccoelho on 2023-08-27 03:27:32+00:00

  1. Initialize the traffic counts with yesterday is not right because it's misleading. If one doesn't know how the package works, he/she will think that the first day had no visitors.
  2. If the computer running the Streamlit server is in a negative timezone, altair/javascript will parse dates wrong and "shift" dates by -1 day. This Stack Overflow thread explains the issue.

See plot below to visualize the two problems:

image

Notice the first day is 0 and that the counting started in 27th august, but there are no pageviews in this day.

@444B
Copy link
Owner Author

444B commented Mar 2, 2024

@mateusccoelho is this still relevant?

@444B 444B self-assigned this Mar 2, 2024
@444B 444B added the bug Something isn't working label Mar 3, 2024
@444B
Copy link
Owner Author

444B commented Mar 11, 2024

@mateusccoelho I believe this is the current design that the first days metrics are not in the middle of the screen.
It starts from the previous day to make a relative comparison and to show the increase or decrease for the days afterwards
I do agree that this could be misleading.

This will be resolved once we introduce more granular timestamp data as requested in #31
Marking this issue as resolved - duplicate and planned work.
Please share insights and comments on #31

@444B 444B closed this as completed Mar 11, 2024
@444B 444B added the future release The issue will be fixed in a future release label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working future release The issue will be fixed in a future release
Projects
None yet
Development

No branches or pull requests

1 participant