Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PullRequest's head missing #89

Closed
BenFradet opened this issue Apr 20, 2017 · 2 comments
Closed

PullRequest's head missing #89

BenFradet opened this issue Apr 20, 2017 · 2 comments

Comments

@BenFradet
Copy link
Contributor

BenFradet commented Apr 20, 2017

I noticed the head field is missing from the PullRequest case class.

Would you guys mind if I added it? Or is there another reason why it's not included?

@fedefernandez
Copy link
Contributor

It was intentional but without any particular reason. We usually don't create complete models, mainly because GitHub doesn't provide a detailed information about what fields are optional or nullables.

Later, when we need a specific field we add it in another pr. Thanks for the ticket, we can use it for add the field.

@BenFradet
Copy link
Contributor Author

It was intentional but without any particular reason. We usually don't create complete models, mainly because GitHub doesn't provide a detailed information about what fields are optional or nullables.

Makes total sense.

Later, when we need a specific field we add it in another pr. Thanks for the ticket, we can use it for add the field.

Yup, that's why I raised the ticket as I actually need the head field, I'll open a PR tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants