fix: OutgoingLinks isExternal defaults to true

47ng · May 27, 2020 · e32ae5b · e32ae5b
1 parent 7ce4555
commit e32ae5b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/components/links.test.tsx b/src/components/links.test.tsx
@@ -29,6 +29,8 @@ describe('Links', () => {
     const element = getByTestId('link')
     expect(element.tagName).toEqual('A')
     expect(element).toHaveAttribute('href', '/foo')
+    expect(element).toHaveAttribute('target', '_blank')
+    expect(element).toHaveAttribute('rel', 'noopener noreferrer')
   })
 
   test('ButtonRouteLink', () => {

diff --git a/src/components/links.tsx b/src/components/links.tsx
@@ -36,11 +36,12 @@ export interface OutgoingLinkProps extends ChakraLinkProps {
 
 export const OutgoingLink: React.FC<OutgoingLinkProps> = ({
   children,
+  isExternal = true,
   showExternalIcon = false,
   ...props
 }) => {
   return (
-    <ChakraLink {...props}>
+    <ChakraLink isExternal={isExternal} {...props}>
       {children}
       {showExternalIcon && (
         <Icon